Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code samples illegible in dark mode on Firefox/Chrome #7

Open
purcell opened this issue May 16, 2021 · 6 comments
Open

Code samples illegible in dark mode on Firefox/Chrome #7

purcell opened this issue May 16, 2021 · 6 comments

Comments

@purcell
Copy link

purcell commented May 16, 2021

Pages like https://counterexamples.org/runtime-misinformation.html apparently adapt to the OS light/dark colour mode: on MacOS in dark mode with Firefox or Chrome, the code snippets are dark text on dark background, and therefore illegible. Curiously, Safari seems okay. Just wanted to let you know - thanks for the resource.

@stedolan
Copy link
Owner

Hmmm, I think this might be rust-lang/mdBook#1304. I'll try upgrading to a more recent version and see if that fixes it.

@purcell
Copy link
Author

purcell commented May 18, 2021

Worth a go, but that issue sounds like Firefox only - I feel like if it had affected Chrome too, someone might have noted it there.

@stedolan
Copy link
Owner

stedolan commented Jun 4, 2021

I tried a few different configs / OSes and I can't reproduce this. Do you have a screenshot? Which MacOS / browser version are you running?

@purcell
Copy link
Author

purcell commented Jun 5, 2021

Screenshot 2021-06-05 at 13 10 41

Latest Firefox, latest MacOS, dark mode set system-wide.

@purcell
Copy link
Author

purcell commented Jun 5, 2021

Screenshot 2021-06-05 at 13 11 59

Latest Chrome on same system.

@purcell
Copy link
Author

purcell commented Jun 5, 2021

Screenshot 2021-06-05 at 13 12 49

Safari is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants