[iOS, Android] Upgrade RN to 0.59.2 #7666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (311)
|
rasom
force-pushed
the
upgrade-to-rn_0.58
branch
3 times, most recently
from
62a13a6
to
3725ea3
Compare
|
RN 0.59 has just been released 😅 |
|
@jeluard well if it's just released it might still contain some regressions which will require updates in some deps, etc... So probably we will need to finish this step first anyway |
rasom
force-pushed
the
upgrade-to-rn_0.58
branch
3 times, most recently
from
77834ab
to
be790a1
Compare
rasom
force-pushed
the
upgrade-to-rn_0.58
branch
12 times, most recently
from
1fc140f
to
af151e0
Compare
rasom
force-pushed
the
upgrade-to-rn_0.58
branch
from
af151e0
to
77580f8
Compare
|
@churik I'm not sure where I have to expect that spinner in |
it is reproducible in PR build and e2e and in develop not, beacuse stickers are hidden in develop. Steps:
|
|
@asemiankevich it is reproducible in |
|
|
|
@rasom 5 looks to me like a blocker for this PR. Is it possible to make upgrade to RN-version without commit that causes the issue or what can we do to avoid this? |
|
@churik |
|
|
I see that's not going to be easy... Working on |
6) header still is cut
7) Replies don't fit box (Android)Steps:
|
|
@churik is that |
|
@churik sorry, I probably just missed it in original comment. really need to finish this task finally :D |
|
@rasom |
rasom
force-pushed
the
upgrade-to-rn_0.58
branch
from
b58a82c
to
96f637f
Compare
|
so |
|
|
|
@churik all regressions found during testing are fixed now |
|
Link to tests: Tested on last builds (IOS 11.4.1, Android 8.1):
Tested on previous builds:
Also checked that Mac O \ Linux \ Windows builds can be installed (fresh install) and used. @rasom please, take 4 my commits when squashing all before merge. |
rasom
force-pushed
the
upgrade-to-rn_0.58
branch
from
78425e3
to
24a978d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
status: ready