Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Dark Mode setting on iOS13 #9470

Closed
errorists opened this issue Nov 18, 2019 · 1 comment · Fixed by #9571
Closed

Ignore Dark Mode setting on iOS13 #9470

errorists opened this issue Nov 18, 2019 · 1 comment · Fixed by #9571

Comments

@errorists
Copy link
Contributor

errorists commented Nov 18, 2019

Problem

At present, whenever dark mode is enabled on iOS, it only introduces a bunch of bugs without any advantages.

  • Status bars are presented white making them invisible against our white backgrounds,

  • photo picker dialogues are presented with incorrect styling all over, making them difficult to use

  • dark keyboards are an unwelcome sight without a Dark Mode of our own.

Implementation

To quote the maestro @flexsurfer

it seems like simple one to ignore dark mode
add this to your Info.plist file:
UIUserInterfaceStyle
Light

Acceptance Criteria

There are no visible changes to our UI when dark mode is enabled.

thank you kindly! 🙏

@errorists errorists added the bug label Nov 18, 2019
rasom added a commit that referenced this issue Dec 2, 2019
rasom added a commit that referenced this issue Dec 2, 2019
rasom added a commit that referenced this issue Dec 2, 2019
rasom added a commit that referenced this issue Dec 2, 2019
Status bar still has to be fixed
@rasom
Copy link
Contributor

rasom commented Dec 2, 2019

All mentioned issues except Status Bar are fixed in #9564.
Status Bar should be fixed with RN upgrade facebook/react-native#26619 (comment)

@rasom rasom self-assigned this Dec 2, 2019
rasom added a commit that referenced this issue Dec 3, 2019
This change allows to fix status bar on iOS in dark mode #9470
rasom added a commit that referenced this issue Dec 3, 2019
This change allows to fix status bar on iOS in dark mode #9470
rasom added a commit that referenced this issue Dec 4, 2019
This change allows to fix status bar on iOS in dark mode #9470
flexsurfer pushed a commit that referenced this issue Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants