Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet-community)_: Move community minting airdrop to router #6196

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

saledjenic
Copy link
Contributor

This PR is about moving community-related txs to the wallet router and aligning the sending flow across the app.

The second commit just duplicated the current communitytokens package and all changes in this PR are done based on that duplicated package.

Once all is done, clients adapted to these changes and tested will be another PR about removing old package.

Changes done here:

  • new file contracts/community-tokens/contracts.go added to unify contracts creation

  • the following community related path processors added:

    • CommunityBurnProcessor
    • CommunityDeployAssetsProcessor
    • CommunityDeployCollectiblesProcessor
    • CommunityDeployOwnerTokenProcessor
    • CommunityMintTokensProcessor
    • CommunityRemoteBurnProcessor
    • CommunitySetSignerPubKeyProcessor
  • SendType extended with appropriate options

  • added endpoints to duplicated communitytokens API:

    • StoreDeployedCollectibles
    • StoreDeployedOwnerToken
    • StoreDeployedAssets
  • removed endpoints from duplicated communitytokens API:

    • DeployCollectibles
    • DeployOwnerToken
    • ReTrackOwnerTokenDeploymentTransaction
    • DeployAssets
    • DeployCollectiblesEstimate
    • DeployAssetsEstimate
    • DeployOwnerTokenEstimate
    • EstimateMintTokens
    • EstimateRemoteBurn
    • EstimateBurn
    • EstimateSetSignerPubKey
    • NewOwnerTokenInstance
    • NewCommunityTokenDeployerInstance
    • NewCommunityOwnerTokenRegistryInstance
    • NewCollectiblesInstance
    • NewAssetsInstance
    • MintTokens
    • RemoteBurn
    • GetCollectiblesContractInstance
    • GetAssetContractInstance
    • Burn
    • SetSignerPubKey

…quests package

`DeploymentParameters` and `DeploymentDetails` types moved from `communitytokens` package
to `requests` of the wallet service.
…outer

- new file `contracts/community-tokens/contracts.go` added to unify contracts creation

- the following community related path processors added:
  - `CommunityBurnProcessor`
  - `CommunityDeployAssetsProcessor`
  - `CommunityDeployCollectiblesProcessor`
  - `CommunityDeployOwnerTokenProcessor`
  - `CommunityMintTokensProcessor`
  - `CommunityRemoteBurnProcessor`
  - `CommunitySetSignerPubKeyProcessor`

- `SendType` extended with appropriate options

- added endpoints to duplicated `communitytokens` api:
  - `StoreDeployedCollectibles`
  - `StoreDeployedOwnerToken`
  - `StoreDeployedAssets`

- removed endpoints from duplicated `communitytokens` api:
  - `DeployCollectibles`
  - `DeployOwnerToken`
  - `ReTrackOwnerTokenDeploymentTransaction`
  - `DeployAssets`
  - `DeployCollectiblesEstimate`
  - `DeployAssetsEstimate`
  - `DeployOwnerTokenEstimate`
  - `EstimateMintTokens`
  - `EstimateRemoteBurn`
  - `EstimateBurn`
  - `EstimateSetSignerPubKey`
  - `NewOwnerTokenInstance`
  - `NewCommunityTokenDeployerInstance`
  - `NewCommunityOwnerTokenRegistryInstance`
  - `NewCollectiblesInstance`
  - `NewAssetsInstance`
  - `MintTokens`
  - `RemoteBurn`
  - `GetCollectiblesContractInstance`
  - `GetAssetContractInstance`
  - `Burn`
  - `SetSignerPubKey`
@status-im-auto
Copy link
Member

status-im-auto commented Dec 11, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 2ab05bf #1 2024-12-11 15:03:09 ~4 min ios 📦zip
✔️ 2ab05bf #1 2024-12-11 15:03:39 ~4 min linux 📦zip
✔️ 2ab05bf #1 2024-12-11 15:04:14 ~5 min android 📦aar
✖️ 2ab05bf #1 2024-12-11 15:04:51 ~5 min tests-rpc 📄log
✔️ 2ab05bf #1 2024-12-11 15:05:16 ~5 min windows 📦zip
✔️ 2ab05bf #1 2024-12-11 15:07:31 ~8 min macos 📦zip
✔️ 2ab05bf #1 2024-12-11 15:09:08 ~9 min macos 📦zip
✖️ 2ab05bf #1 2024-12-11 15:29:55 ~30 min tests 📄log
✔️ 7bc48bf #2 2024-12-12 14:08:08 ~3 min macos 📦zip
✔️ 7bc48bf #2 2024-12-12 14:08:14 ~3 min ios 📦zip
✔️ 7bc48bf #2 2024-12-12 14:08:43 ~4 min windows 📦zip
✔️ 7bc48bf #2 2024-12-12 14:08:49 ~4 min linux 📦zip
✔️ 7bc48bf #2 2024-12-12 14:09:28 ~5 min android 📦aar
✖️ 7bc48bf #2 2024-12-12 14:10:36 ~6 min tests-rpc 📄log
✔️ 7bc48bf #2 2024-12-12 14:13:08 ~8 min macos 📦zip
✖️ 7bc48bf #2 2024-12-12 14:33:41 ~29 min tests 📄log

@saledjenic
Copy link
Contributor Author

Next step is to remove the code below and related functions, that should be on the wallet service to take care of transactions.

image

@saledjenic saledjenic changed the title Move community minting airdrop to router chore(wallet-community)_: Move community minting airdrop to router Dec 11, 2024
Copy link

We require commits to follow the Conventional Commits, but with _ for non-breaking changes.
Please fix these commit messages:

u1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants