-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unfurl Status deep links #3762
Comments
ProblemCurrent
|
type LinkPreview struct { | |
Type protobuf.UnfurledLink_LinkType `json:"type"` | |
URL string `json:"url"` | |
Hostname string `json:"hostname"` | |
Title string `json:"title,omitempty"` | |
Description string `json:"description,omitempty"` | |
Thumbnail LinkPreviewThumbnail `json:"thumbnail,omitempty"` | |
} |
URLDataResponse
status-go/protocol/messenger_share_urls.go
Lines 43 to 47 in 09a9886
type URLDataResponse struct { | |
Community CommunityURLData `json:"community"` | |
Channel CommunityChannelURLData `json:"channel"` | |
Contact ContactURLData `json:"contact"` | |
} |
status-go/protocol/messenger_share_urls.go
Lines 20 to 42 in 09a9886
type CommunityURLData struct { | |
DisplayName string `json:"displayName"` | |
Description string `json:"description"` | |
MembersCount uint32 `json:"membersCount"` | |
Color string `json:"color"` | |
TagIndices []uint32 `json:"tagIndices"` | |
CommunityID string `json:"communityId"` | |
} | |
type CommunityChannelURLData struct { | |
Emoji string `json:"emoji"` | |
DisplayName string `json:"displayName"` | |
Description string `json:"description"` | |
Color string `json:"color"` | |
ChannelUUID string `json:"channelUuid"` | |
} | |
type ContactURLData struct { | |
DisplayName string `json:"displayName"` | |
Description string `json:"description"` | |
PublicKey string `json:"publicKey"` | |
} | |
Problem
New URL unfurling scheme was implemented in #3471.
We should also unfurl status deep links on sender side and include a preview in the message.
UnfurlURLs
should follow this flow for Status deep links:I'm not sure if this step makes sense, because we plan to unfurl it in step 2.
At the same time, the receiver will update the preview on reception anyway. so maybe this step is important and step 2 is redundant.
RequestContactInfoFromMailserver
for profileRequestCommunityInfoFromMailserver
for communityThere should be no more info than a Status deep link with data would contain.
Acceptance Criteria
UnfurlURLs
should unfurl Status deep links for:Future Steps
Support the solution in desktop/mobile.
The text was updated successfully, but these errors were encountered: