-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor access with proper mutex guard #258
Comments
Actually we already got a lot of dara races in |
Closed
I done most of 403 to complite this task:
|
@divan @adambabik closing in favour of status-im/swarms#63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we have in
geth/node/manager.go
(see https://github.com/status-im/status-go/blob/develop/geth/node/manager.go#L35-L45), where we have both intention in code to guard synchronous access to most fields through the embedded mutex.Problem
But we currently have in https://github.com/status-im/status-go/blob/develop/geth/node/manager.go#L69-L71 and in many other areas within code where access to
NodeManager.node
is initially accessed without mutex guard to ensure synch access.Issues
We could later face issues with race conditions on access to the
NodeManager.node
field and other fields that maybe concurrently reacehed directly or indirectly.Fix
We need to refactor this package to ensure proper synchronouse access to the
NodeManager.node
and other fields as intended, else re-arrangeNodeManager
struct fields to ensure quick intention has to fields which mutex guards.The text was updated successfully, but these errors were encountered: