You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Rename methods of the common.JailCell interface:
CellVM() -> VM()
CellLoop() -> Loop()
Get rid of duplicated code in common.Jail struct methods: Call, JailCell, JailCellVM, GetCell.
Get rid of the Jail prefix everywhere in the jail package.
Rewrite tests to use jail.NewJailCell instead of jailInstance.Parse(testChatID, ``).
In JailTestSuite initialise the internal jail with BaseJS in SetupSuite and initialise a test jail cell in SetupTest. The idea is to make those tests as meaningful as possible avoiding as much extra scaffolding as we can.
Refactor all tests to use testify asserts. Tests become twice as short and twice as meaningful.
Figure out if one of Jail.GetJailCell and Jail.GetCell could be removed. This looks like rather an architecture issue.
See if it's possible to invoke jail.BaseJS in setup methods in JailTestSuite instead of doing it in every test.
As this is a refactoring issue, it must be finished and merged within a day. Please, plan accordingly.
If you have new refactoring notes during implementing these, write them into #200.
The text was updated successfully, but these errors were encountered:
common.JailCell
interface:CellVM() -> VM()
CellLoop() -> Loop()
Jail
prefix everywhere in thejail
package.jail.NewJailCell
instead ofjailInstance.Parse(testChatID, ``)
.testify
asserts. Tests become twice as short and twice as meaningful.Jail.GetJailCell
andJail.GetCell
could be removed. This looks like rather an architecture issue.jail.BaseJS
in setup methods in JailTestSuite instead of doing it in every test.As this is a refactoring issue, it must be finished and merged within a day. Please, plan accordingly.
If you have new refactoring notes during implementing these, write them into #200.
The text was updated successfully, but these errors were encountered: