Skip to content

Commit

Permalink
fix_: use pr comment
Browse files Browse the repository at this point in the history
  • Loading branch information
igor-sirotin committed Aug 27, 2024
1 parent 2b6b54a commit 1f8ff2d
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 47 deletions.
89 changes: 42 additions & 47 deletions .github/workflows/commit-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,61 +6,56 @@ on:
- opened
- edited
- synchronize

jobs:
main:
name: Validate format
runs-on: ubuntu-latest
# permissions:
# pull-requests: write
permissions:
pull-requests: write
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Check commit message
run: |
make commit-check
echo "Test check description" > status.txt
- uses: octokit/[email protected]
id: create_check_run
with:
route: POST /repos/{repo}/check-runs
repo: ${{ github.repository }}
name: "Test check run"
head_sha: ${{ github.sha }}
output: |
title: Test check run title
summary: A summary of the test check run
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# - uses: amannn/action-semantic-pull-request@v5
# id: lint_pr_title
# env:
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
#
# - uses: richard-ramos/[email protected]
# id: lint_pr_commits
# - uses: marocchino/sticky-pull-request-comment@v2
# # When the previous steps fails, the workflow would stop. By adding this
# # condition you can continue the execution with the populated error message.
# if: always() && (steps.lint_pr_title.outputs.error_message != null || steps.lint_pr_commits.outputs.error_message != null )
# with:
# header: pr-title-lint-error
# message: |
# Thank you for opening this pull request!
#
# We require pull request titles and commits to follow the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/) and it looks like your PR needs to be adjusted.
#
# Details:
#
# > ${{ steps.lint_pr_title.outputs.error_message }}
# > ${{ steps.lint_pr_commits.outputs.error_message }}
#
# # Delete a previous comment when the issue has been resolved
# - if: ${{ steps.lint_pr_title.outputs.error_message == null && steps.lint_pr_commits.outputs.error_message == null }}
# uses: marocchino/sticky-pull-request-comment@v2
# with:
# header: pr-title-lint-error
# delete: true

- name: Check commit message
id: check_commit_message
run: |
output=$(make commit-check)
exit_code=$?
error_message=$(echo "$output" | sed -n '2p')
has_breaking_changes=$(echo "$output" | sed -n '3p')
echo "exit_code=$exit_code" >> $GITHUB_OUTPUT
echo "error_message=$error_message" >> $GITHUB_OUTPUT
echo "has_breaking_changes=$has_breaking_changes" >> $GITHUB_OUTPUT
- uses: marocchino/sticky-pull-request-comment@v2
# When the previous steps fails, the workflow would stop. By adding this
# condition you can continue the execution with the populated error message.
if: always() && (steps.lint_pr_title.outputs.error_message != null || steps.lint_pr_commits.outputs.error_message != null )
with:
header: pr-title-lint-error
message: |
Thank you for opening this pull request!
We require pull request titles and commits to follow the [Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/), but with `_` for non-breaking changes.
And it looks like your PR needs to be adjusted.
Details:
```
${{ steps.check_commit_message.outputs.exit_code }}
${{ steps.check_commit_message.outputs.error_message }}
${{ steps.check_commit_message.outputs.has_breaking_changes }}
```
# Delete a previous comment when the issue has been resolved
- if: ${{ steps.lint_pr_title.outputs.error_message == null && steps.lint_pr_commits.outputs.error_message == null }}
uses: marocchino/sticky-pull-request-comment@v2
with:
header: pr-title-lint-error
delete: true
1 change: 1 addition & 0 deletions _assets/scripts/commit_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ parse_commits() {
fi
done < <(git log --format=%s "$start_commit".."$end_commit")

echo "Commit messages are ok, thank you"
echo "$is_breaking_change"
}

Expand Down

0 comments on commit 1f8ff2d

Please sign in to comment.