Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index required wallet connect DB columns before enabling the feature #14975

Open
2 tasks
stefandunca opened this issue May 29, 2024 · 0 comments
Open
2 tasks
Assignees
Labels
dapp-interactions E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs wallet-team

Comments

@stefandunca
Copy link
Contributor

As reported by @cammellos the following columns (and any used in the meantime) should be indexed

  • wallet_connect_sessions

    • disconnected, expiry, test_chains (WHERE clause)
    • optionally: pairing_topic
    • already indexed: topic
  • wallet_connect_dapps

    • url is primary key
  • Run explain query plan .... for all the queries we do and ensure the index is used

  • Optionally implement basic benchmarks for the usual operations "list dapps", "disable a session", "disable all sessions for pairing topic" ...

@stefandunca stefandunca added E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs dapp-interactions labels May 29, 2024
@stefandunca stefandunca added this to the 2.30.0 Beta milestone May 29, 2024
@clauxx clauxx moved this to Iteration Backlog in Status Desktop/Mobile Board Jun 5, 2024
@clauxx clauxx moved this from Iteration Backlog to Next Iteration in Status Desktop/Mobile Board Jun 5, 2024
@clauxx clauxx modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 15, 2024
@alexjba alexjba mentioned this issue Sep 11, 2024
23 tasks
@alaibe alaibe modified the milestones: 2.31.0 Beta, 2.32.0 Beta Oct 6, 2024
@alexjba alexjba moved this to In Progress in Status Desktop/Mobile Board Oct 24, 2024
@alexjba alexjba self-assigned this Oct 24, 2024
@jrainville jrainville modified the milestones: 2.32.0 Beta, 2.33.0 Beta Dec 4, 2024
@alaibe alaibe modified the milestones: 2.33.0 Beta, 2.34.0 Beta Jan 28, 2025
@iurimatias iurimatias removed this from the 2.34.0 Beta milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dapp-interactions E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs wallet-team
Projects
Status: In Progress
Development

No branches or pull requests

6 participants