Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Implement DB connection pool to wrap go-sqlcipher connection #10723

Closed
Tracked by #10558
alexjba opened this issue May 17, 2023 · 2 comments
Closed
Tracked by #10558
Assignees
Milestone

Comments

@alexjba
Copy link
Contributor

alexjba commented May 17, 2023

Description

Context: The current go-sqlcipher implementation does not support async read/write. This means that both reading and writing are blocking operations.

The goal of this task is to create a DB connection pool and delegate DB operations to different connections based on availability.

Pool configuration (based on these findings #10611):

  1. write operations can be done on a dedicated connection (to avoid database is locked or table is locked errors)
  2. The most efficient connection pool size is 10
@osmaczko
Copy link
Contributor

Should we close this one in favor of status-im/status-go#3507 ?

@alexjba
Copy link
Contributor Author

alexjba commented May 23, 2023

Closing in favour of status-im/status-go#3507

@alexjba alexjba closed this as completed May 23, 2023
@github-project-automation github-project-automation bot moved this from Code review to Done in Status Desktop/Mobile Board May 23, 2023
@iurimatias iurimatias added this to the 0.13 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants