Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace nim's std/nre with nim-regex library #1327

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 2, 2022

Nim's standard library std/nre loads at runtime (via dlopen()) the libpcre.so.3.

This is not portable enough. This shared library name differs depending on the Linux distributions (e.g., in Linux Arch, the shared object is named libpcre.so.0).

  • Replace std/nre with nitely/nim-regex library

For more context, check this forum thread and this comment

@LNSD LNSD requested review from alrevuelta and jm-clius November 2, 2022 11:42
@LNSD LNSD self-assigned this Nov 2, 2022
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 2, 2022

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e7516ae #1 2022-11-02 11:59:19 ~16 min macos 📦bin
✔️ e7516ae #1 2022-11-02 12:01:11 ~18 min linux 📦bin

Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know much about this issue, but based on forum thread this seems to be the accepted solution.

@LNSD LNSD merged commit 0e1dae5 into master Nov 2, 2022
@LNSD LNSD deleted the fix-regex-dependency branch November 2, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants