-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDY] improve compile time tests coverage #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jangko
force-pushed
the
compile_time_tests
branch
from
October 22, 2019 12:51
3c2c8e5
to
4bd3183
Compare
this PR is ready for review.
|
jangko
changed the title
[WIP] improve compile time tests coverage
[RDY] improve compile time tests coverage
Oct 23, 2019
mratsim
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great to me :)
arnetheduck
approved these changes
Oct 23, 2019
@kdeme this looks like an interesting fuzzing target, wouldn't you say? |
This was referenced Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to have 100% coverage for all exported API to pass compile time test.
The compile time helpers implementation might be not efficient, but first make it run then make it run fast.
As a bonus, it also improve runtime coverage.
zero, negative numbers, hi and lo tests also added if possible.
Inputs are welcome.