Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only start sending messages when connected to > 1 peers? #106

Closed
kdeme opened this issue Oct 21, 2019 · 3 comments
Closed

Only start sending messages when connected to > 1 peers? #106

kdeme opened this issue Oct 21, 2019 · 3 comments
Labels
Waku Issues related to Waku Swarm Whisper wontfix This will not be worked on

Comments

@kdeme
Copy link
Contributor

kdeme commented Oct 21, 2019

Perhaps we should add a check of x connected peers before we start sending Whisper messages at the specified interval.

If a node is only connected to 1 peer, and that peer is malicious, it could decide not to forward the node its messages.
In this case, the malicious peer could monitor with all it's connected peers if any duplicates of the node its messages are arriving. If this does not occur, it could mean that the messages originates from that node. It could of course also just mean, that the TTL is not long enough to get forwarded all the way to this peer. However, with a low amount of nodes (which Status kinda has), and over several messages, the malicious peer could probably deduce this.

This might be a none issue, especially if a node is only for a very limited time (like @ startup) connected to only 1 node.

@arnetheduck
Copy link
Member

sounds like something that could be generalized into a privacy score/metric where peer diversity and other heuristics are considered. of course, it's gameable, but at least then then we can add other components than peer count specifically to make it harder.

@cheatfate
Copy link
Contributor

It is better to consider only outgoing peers, not incoming peers.

@kdeme kdeme added the Waku Issues related to Waku Swarm label Dec 18, 2019
@kdeme kdeme added the wontfix This will not be worked on label Nov 16, 2022
@kdeme
Copy link
Contributor Author

kdeme commented Nov 16, 2022

Whisper/Waku code was moved out of nim-eth

@kdeme kdeme closed this as completed Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waku Issues related to Waku Swarm Whisper wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants