Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add comments to docs #2358

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add comments to docs #2358

wants to merge 1 commit into from

Conversation

daniel-statsig
Copy link
Contributor

Screenshot 2024-11-18 at 8 56 14 PM

reactionsEnabled="1"
emitMetadata="1"
inputPosition="bottom"
theme={colorMode}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theme prop expects specific values from Giscus, and colorMode won't work here. Using theme="preferred_color_scheme" will allow Giscus to properly handle light/dark mode switching based on the user's system preferences.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@jasonwzm
Copy link
Member

@jasonwzm jasonwzm temporarily deployed to pull request November 19, 2024 04:59 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants