Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MAP@k #49

Closed
j-adamczyk opened this issue Oct 29, 2022 · 4 comments · Fixed by #50 or #51
Closed

Implement MAP@k #49

j-adamczyk opened this issue Oct 29, 2022 · 4 comments · Fixed by #50 or #51

Comments

@j-adamczyk
Copy link

MAP@k implementation linked in the documentation (https://github.com/benhamner/Metrics) has not been updated for 7 years and has bugs in MAP@k implementation (e.g. benhamner/Metrics#51, benhamner/Metrics#57). It would be really useful to have MAP@k implementation in recmetrics. Would it be possible to implement it? It would be almost identical to the existing mark() function.

@j-adamczyk
Copy link
Author

Also, is MAR@k correct? It is almost exactly the MAP@k from ml_metrics, but with one bug fixed in the last line.

@Alex-Bujorianu
Copy link

I have this issue too. How can something so basic not be implemented in a library named recmetrics?

@statisticianinstilettos
Copy link
Owner

Hey everyone! Thanks for the feedback. I'd love to implement MAP@k in recmetrics, but I dont have the bandwidth today (I work for a startup :-) ) If anyone from the community is interested in contributing, I can review PRs and get it merged.

@statisticianinstilettos
Copy link
Owner

Thanks dream team. Love the community contributions to this one. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants