Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main and Header Have Fixed Padding and Margin #3

Open
andyleach opened this issue Nov 21, 2018 · 1 comment
Open

Main and Header Have Fixed Padding and Margin #3

andyleach opened this issue Nov 21, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@andyleach
Copy link
Collaborator

These element have fixed padding and margin, while our goal might be to not use utility classes, it might be worth using some very simple ones to handle this rather than attaching it to the element itself. This way we can have more flexibility with child elements we end up creating. Example below:

image

@andyleach andyleach added the enhancement New feature or request label Nov 22, 2018
@tyleruebele
Copy link
Contributor

We'll need to rethink much of the _layout layer to reduce it to suitable defaults, instead of what suited the style guide. That said, utility classes are not the answer. Padding the main might be a job for a consuming project's _theme layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants