Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate output item for stderr? #1831

Open
sourishkrout opened this issue Dec 2, 2024 · 1 comment
Open

Separate output item for stderr? #1831

sourishkrout opened this issue Dec 2, 2024 · 1 comment
Assignees

Comments

@sourishkrout
Copy link
Member

As follow up for #1763. We still need to resolve.

Btw, this PR does not solve how to include stderr into the serialized notebook, as per:

and for non-interactive we could probably do:

  • stateful.runme/output-items
  • application/vnd.code.notebook.stdout
  • perhaps a third with application/vnd.code.notebook.stderr

Would a separate application/vnd.code.notebook.stderr output item work for you, @jlewi? Alternatively, stderr could be merged into the ``application/vnd.code.notebook.stdout` output item.

@jlewi
Copy link
Contributor

jlewi commented Dec 4, 2024

Yes; I think a separate output item would work fine. This would allow Foyle to easily include the stderr in the model prompt.

To consider the alternative, I think one downside of not merging stdout/stderr is that it can be harder to do so after the fact. So if a program is mixing stdout and stderr then errors might miss important contextual information. However, in this case we are talking about non-interactive mode and a motivation for using non-interactive mode (#684) is non-standard renderers. If your using a non-standard renderer then that arguably implies "stdout" and "stderr" should contain different content (e.g. JSON; vs. errors) and shouldn't be merged because that would interfere with the renderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants