[5.x] Cache results of getComputedCallbacks for a given scope
#9640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
jasonvarga
previously requested changes
Mar 7, 2024
JohnathonKoster
changed the title
getComputedCallbacks for a given scopegetComputedCallbacks for a given scope
jasonvarga
requested changes
Mar 12, 2024
There was a problem hiding this comment.
I don't think this is suitable. Maybe if the blink key also contained the class name.
I know at the moment we only use this trait on collections, but lets say we also used it on taxonomies...
Collection::getComputedCallbacks('foo');
Taxonomy::getComputedCallbacks('foo');These would both return the same items since they share a blink key.
Blink keys are now prefixed with the calling class name 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR caches the results of
getComputedCallbacksfor a given scope