Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues from #9612. The following two breaking changes are super low impact and probably only used by us in the core anyway.
Provider::label()
is now just a getter.To configure a label, pass it in the config.
The way a user would define the label is within the config file - not in PHP - and that doesn't change at all.
User
/UserRepository::findByOAuthId()
now accepts a provider instance rather than the name string.This allows us to avoid re-fetching the provider instance. Probably the only place this is ever called is from within the core where we are already in that provider instance. The config was removed from the test since it no longer has to do another lookup.