Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Prevent "Set Alt" button from running Replace Asset action prematurely #11269

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request prevents the "Set Alt" button from running the Replace Asset action prematurely. Without explicitly setting the type attribute on buttons, it'll automatically submit the <form> it's located in, which was the issue here.

Fixes #11260.

@jasonvarga jasonvarga merged commit b70a97b into 5.x Dec 17, 2024
18 checks passed
@jasonvarga jasonvarga deleted the prevent-set-alt-submitting-replace-asset-form branch December 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When replacing an asset and setting alt, it closes the window
2 participants