[5.x] Fix ordering search results by date #10939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where it wasn't possible to order entry search results by
date
.Essentially, when you order search results, it uses the
DataCollection::multisort()
method to perform the ordering. As part of that, it tries to get the value of thedate
field using this code below:cms/src/Data/DataCollection.php
Lines 99 to 101 in 7bf2816
The
->get()
here defers to theResult::get()
method, which will do->get('date')
on the entry. However, since dates aren't part of an entry's data, it was trying to order results bynull
.This PR fixes that by checking if the
$key
isdate
and deferring to the entry'sdate
method instead.Fixes #10892.