[5.x] Improve AssetFolderPolicy
performance
#10868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our
AssetFolderPolicy
, we are currently performing a whole bunch of redundant ability checks, which really slows down performance in super large asset containers.For example, this ability check is done in our
AssetFolderPolicy
:But then right after that, you can see we loop over every asset in the folder:
Which essentially just does the same ability check within
AssetPolicy
:This PR changes improves performance by only looping over each asset if a custom
AssetPolicy
class is registered. If a custom policy is registered, there is likely extra logic that run to be checked on an asset-by-asset basis, so we'll do the more thorough check only in those scenarios.Fixes #9710