Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] License banner is snoozable #10590

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

duncanmcclean
Copy link
Member

As suggested on this issue, it'd be nice if clicking "Dismiss" on the license banner meant it'd actually go away when navigating to other pages.

This PR makes that a reality, dismissing the banner will hide it for 5 minutes.

Closes #10564.

@duncanmcclean duncanmcclean marked this pull request as ready for review August 7, 2024 16:10
@jasonvarga jasonvarga changed the title [5.x] Hide license banner for 5 minutes after dismissing it [5.x] License banner is snoozable Aug 7, 2024
@jasonvarga jasonvarga merged commit 4f8f2e6 into 5.x Aug 7, 2024
17 checks passed
@jasonvarga jasonvarga deleted the dismiss-the-license-banner-for-five-minutes branch August 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when running local and pro version the licenses banner is getting the way
2 participants