Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Sync datetime dark mode with control panel #10488

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

peimn
Copy link
Contributor

@peimn peimn commented Jul 22, 2024

The V-Calendar component features a dark mode using shades of blue, but it isn't synchronized with the control panel.

Fixes #10482.

@peimn
Copy link
Contributor Author

peimn commented Jul 22, 2024

This PR addresses #10482

Copy link
Member

@jasonvarga jasonvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the style was there, it wasn't necessary to add any more.

Instead, I've made a Statamic.darkMode reactive property which gets used in the component's prop. The way it was reading the preference before was not correct since it may have been "auto".

@jasonvarga jasonvarga merged commit b31422f into statamic:5.x Jul 22, 2024
15 checks passed
@peimn
Copy link
Contributor Author

peimn commented Jul 22, 2024

@jasonvarga yes, it did have a problem. However, the style of the date-time picker has a blue tint in dark mode. Please look at the screenshots below:
image
image

Is it not necessary to make them the same? cp and date picker.

@jasonvarga
Copy link
Member

Ah sorry I see what you mean. I will leave it to @jackmcdade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dark] Date Field Calendars
2 participants