[5.x] Use StaticCache facade in Cache Manager utility #10456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes how the Cache Manager utility clears the static cache, to bring it inline with the
static:clear
command.Currently, the
static:cache
command calls theStaticCacheManager::flush()
method. However, the "Clear" button on the cache manager utlity calls the cacher'sflush
method (eg.FileCacher::flush()
orApplicationCacher::flush()
).The
flush
method on theStaticCacheManager
does end up calling the cacher'sflush
method but it also deals with clearing other static caching related stuff from the cache (like nocache URLs).This isn't causing any issues right now, however, as part of #10403, I'm adding a
StaticCacheCleared
event which I'd like to be able to dispatch in one place (theStaticCacheManager
, rather than in two places).