Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Use StaticCache facade in Cache Manager utility #10456

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

duncanmcclean
Copy link
Member

This pull request changes how the Cache Manager utility clears the static cache, to bring it inline with the static:clear command.

Currently, the static:cache command calls the StaticCacheManager::flush() method. However, the "Clear" button on the cache manager utlity calls the cacher's flush method (eg. FileCacher::flush() or ApplicationCacher::flush()).

The flush method on the StaticCacheManager does end up calling the cacher's flush method but it also deals with clearing other static caching related stuff from the cache (like nocache URLs).

This isn't causing any issues right now, however, as part of #10403, I'm adding a StaticCacheCleared event which I'd like to be able to dispatch in one place (the StaticCacheManager, rather than in two places).

@duncanmcclean duncanmcclean changed the title [5.x] Ensure cache manager clears the static cache the same way as `static:… [5.x] Cache Manager utility: clear static cache the same way as static:clear command Jul 15, 2024
@jasonvarga jasonvarga changed the title [5.x] Cache Manager utility: clear static cache the same way as static:clear command [5.x] Use StaticCache facade in Cache Manager utility Jul 15, 2024
@jasonvarga jasonvarga merged commit ebfcad3 into 5.x Jul 15, 2024
17 checks passed
@jasonvarga jasonvarga deleted the clear-static-cache-from-cache-manager-utility branch July 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants