[5.x] Paginate folders in asset browser #10419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(duncan i know you used 15 because you took it from https://github.com/statamic/cms/blob/4495b6d77d8379c819765e342ef4a59523b5860b/src/Query/Builder.php#L71 👍)
duncanmcclean
added a commit
that referenced
this pull request
Oct 14, 2024
The `actions` array wasn't being returned for individual folders, only for the "current" folder. This was probably caused by the changes in #10419.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the performance of the Asset Browser for asset containers with lots of folders.
Currently, the asset browser displays all folders, all of the time, even when the user navigates between paginated pages.
However, this behaviour is less than ideal for asset containers with lots of folders because it means you might need to scroll for a while to see actual assets and that the AJAX request for fetching folders/assets takes longer than it really needs to.
To address this issue, we've decided to start including folders in the asset browser's pagination, which reduces the number of folders being returned in individual requests, which will subsequentally improve performance.
No issue related to this one, just a support ticket (no 5623).