[5.x] Merge additional params after SVG sanitization #10400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that the SVG tag adds additional parameters after sanitization. This solves the problem of parameters being unintentionally removed by the sanitizer.
Until 5.0 this was possible without any issues:
But since 5.0 this has changed, as sanitizing is active by default:
We can set
sanitize="false"
of course. But in my opinion, it would be nicer to have the best of both worlds. First sanitizing potentially dangerous code, then merge additional parameters.This relates to #9948 and potentially to #10161 as well.