[5.x] Fix unauthorized page logout redirect #10378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonvarga
approved these changes
Jul 1, 2024
|
Thanks for fixing those small bits @jasonvarga 🙌🏼 |
|
No worries, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the release of v5.12.0, developers can now disable the CP authentication pages. However, if a user is unauthorized to access the control panel, an unexpected exception is thrown.
This is due to the
unauthorizedview attempting to use the login route as the redirect after logging out, however, that route will no longer be registered if CP authentication is disabled.Therefore, to solve this, I've added a check in the
UnauthorizedControllerto check whether the CP authentication pages are enabled. If they are, we will redirect to the login page after logout, otherwise, we will redirect back to URL specified in the config.