[5.x] Prevent adding content to Blade stacks twice #10271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents prepending/pushing stack contents twice to a Blade stack. This seems to be the root cause of #10258, but would need help to validate this. This issue can be reproduced by utilizing a Blade template and a Blade layout together.
The changes in this PR address this by not invoking the interop logic to push to Blade if the request is coming from Blade itself. I've added another example page to https://github.com/JohnathonKoster/statamic-antlers-blade-stacks with this setup configured (simply navigate to
/blade-routeto observe the before/after behaviors).