Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Fix failed slug validation when slug contains underscores #10265

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

o1y
Copy link
Contributor

@o1y o1y commented Jun 5, 2024

Fixes #10262

@o1y o1y changed the title Fix failed slug validation when slug contains underscores [5.x] Fix failed slug validation when slug contains underscores Jun 5, 2024
@jasonvarga
Copy link
Member

Thanks. I wonder if we intentionally didn't allow underscores in slugs, even though the validation message says they are okay.

I don't think it's a problem for them to contain underscores though. It's just a bit derpy looking but thats subjective. Unless I'm forgetting something, @jesseleite ?

@jesseleite
Copy link
Member

jesseleite commented Jun 5, 2024

Given the validation error message in my original PR, it seems underscores should be allowed. Maybe there's an edge case somewhere, where we don't want to allow underscores? ...but I cannot think of where! 👍

@jasonvarga jasonvarga merged commit 694a26a into statamic:5.x Jun 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entry can't be saved if the Slug contains underscore
3 participants