Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Allow overriding statusIcons property in relationship fieldtype #10253

Merged

Conversation

duncanmcclean
Copy link
Member

@duncanmcclean duncanmcclean commented Jun 3, 2024

This pull request adds a new method to allow overriding the statusIcons property in Relationship Fieldtypes.

For context: in Runway, I'm adding the concept of "publish states". This will be an opt-in feature, so the status icons are only needed when it's enabled.

@jasonvarga jasonvarga merged commit 18c0bb3 into 5.x Jun 3, 2024
19 checks passed
@jasonvarga jasonvarga deleted the allow-overriding-status-icons-in-relationship-fieldtype branch June 3, 2024 16:41
duncanmcclean added a commit to statamic-rad-pack/runway that referenced this pull request Jun 3, 2024
duncanmcclean added a commit to statamic-rad-pack/runway that referenced this pull request Jun 3, 2024
* Add `published` config option

* Add "Published" toggle to publish forms

* Add status indicator to listing tables

* Pass the `canManagePublishState` prop to inline publish forms

* Ensure the `published` field never becomes the title field

* Show status indicator in fieldtype

Related: statamic/cms#10253

* Ensure the publish column is dynamic

* Add `runwayStatus` query scope to filter models based on status

* Re-word documentation

* Add `status` parameter to filter models by publish state

* Prevent accessing unpublished models via URL

* Avoid unpublished models being returned by the REST API

* Avoid unpublished models being returned by the GraphQL API

* Avoid unpublished models being returned by search provider

* Only add "Published" column when resource has publish states enabled

* Enable publish states for posts model in tests

* *Actually* avoid unpublished models being returned by search provider

* Add test to ensure unpublished entries aren't accessible via URL

* Allow filtering models by status in GraphQL API

* Only return published models using GraphQL show query

* Add tests to ensure unpublished models get filtered out

Most of the added code in this commit is moving around some of the tests in the file, rather than adding a lot new code.

* Allow filtering models by status in REST API

* Rename query scope to match name in entry query builder

* Pass the `published` column through in some tests

* Tweak stuff in the publish form

* Fix publish toggle on inline publish forms

* Publish models by default

* Don't hard code this

* Fix issue with published toggle being appended to blueprint incorrectly

* Add "Status" filter to listing table

* Fix styling

* Add Publish & Unpublish actions

* Fix styling

* wip

---------

Co-authored-by: duncanmcclean <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants