[5.x] Decrease the failure rate of RandomTest #10238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pesky test fails every now and then and has finally got under my skin enough to fix it.
We copied the test from the
shuffletest - where this made more sense. Theshufflemodifier gives you back a 26-item array. That's a huge number of combinations.But in the
randommodifier, it's pulling one item out of the 26. The odds of you picking the same single number out of 26 is much higher.This PR bumps 26 possibilities to 5000. If we see a failure now, buy a lottery ticket.