[5.x] Implement translations for dictionary keys used in titles shown in breadcrumb trails #10039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/CP/Breadcrumbs.php
Outdated
| @@ -37,7 +37,8 @@ public function jsonSerialize() | |||
|
|
|||
| public function title($title = null) | |||
| { | |||
| $crumbs = $this->crumbs->map->text; | |||
| $new_crumbs = $this->crumbs->map(fn ($v) => ['text' => __($v['text']), 'url' => $v['url']]); | |||
There was a problem hiding this comment.
maybe simplify to $crumbs = $this->crumbs->map(fn ($v) => __($v['text'])) ?
|
What page is this an issue on? |
This title is automatically generated for all pages and displays the path. For example, if a page is opened from a collection, the title of the page will be If a key, such as This change will translate the title. |
|
But where are you seeing this long breadcrumb? On an entry, it's just
|
|
Ah the |
jasonvarga
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.