[4.x] Fix EloquentQueryBuilder orderby bug #10023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the recently introduced
EloquentQueryBuilder@enforceOrderBy
method, where it was trying to access thequery
property on the Eloquent query builder instance.However, that property is protected so it errored so couldn't be accessed by the
__get
method inside Eloquent.Stack trace:
This PR fixes that issue by calling the
getQuery
method on the builder instead of calling thequery
property directly.Caused by #9956.