[Bug Report] DLNA not working on Samsung TV

[ctyjiuh]

Describe the bug
DLNA on Samsung TV (Tizen OS) not working

To Reproduce
Steps to reproduce the behavior:

1. Go to "Sources"
2. Choose
3. See "no content"

Expected behavior
Folders with content

Screenshots
Here is config screen

Stash Version: (from Settings -> About):
Version: v0.9.0
Build hash: a73c99a
Build time: 2021-09-06 04:27:29
Latest Version Build Hash: a73c99a
Running on Docker with macvlan driver

Desktop (please complete the following information):

• OS: Tizen OS
• Version T-KTSU2DEUC-2013.3

Additional context
Here is debug level output from Logs section in Stashapp web interface

021-09-25 13:47:08
Debug   
< map[NumberReturned:1 Result:<DIDL-Lite xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns="urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/" xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/"><container id="0" parentID="-1" restricted="1" searchable="0" childCount="1"><upnp:class>object.container.storageFolder</upnp:class><dc:title>stash</dc:title></container></DIDL-Lite> TotalMatches:1 UpdateID:1]

2021-09-25 13:47:08
Debug   
ContentDirectory::Handle Browse - <u:Browse xmlns:u="urn:schemas-upnp-org:service:ContentDirectory:1"><ObjectID>0</ObjectID><BrowseFlag>BrowseMetadata</BrowseFlag><Filter>*</Filter><StartingIndex>0</StartingIndex><RequestedCount>0</RequestedCount><SortCriteria></SortCriteria></u:Browse>

2021-09-25 13:47:08
Debug   
< map[NumberReturned:1 Result:<DIDL-Lite xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:upnp="urn:schemas-upnp-org:metadata-1-0/upnp/" xmlns="urn:schemas-upnp-org:metadata-1-0/DIDL-Lite/" xmlns:dlna="urn:schemas-dlna-org:metadata-1-0/"><container id="0" parentID="-1" restricted="1" searchable="0" childCount="1"><upnp:class>object.container.storageFolder</upnp:class><dc:title>stash</dc:title></container></DIDL-Lite> TotalMatches:1 UpdateID:1]

2021-09-25 13:47:08
Debug   
ContentDirectory::Handle Browse - <u:Browse xmlns:u="urn:schemas-upnp-org:service:ContentDirectory:1"><ObjectID>0</ObjectID><BrowseFlag>BrowseMetadata</BrowseFlag><Filter>*</Filter><StartingIndex>0</StartingIndex><RequestedCount>0</RequestedCount><SortCriteria></SortCriteria></u:Browse>

2021-09-25 13:47:02
Debug   
started SSDP on eth0

2021-09-25 13:47:01
Debug   
HTTP srv on0.0.0.0:1338

Meanwhile I open VLC app on my Android Smartphone and DLNA works - showing folders with rating, tags, etc.

[philpw99]

I am not an expert in DLNA, so this is just a speculation: if Stash's DLNA works in smartphones, doesn't that means it works fine? The Samsung TV is the actual problem? Maybe you can get a media player that supports DLNA and see what happens?

[ctyjiuh]

That can be useful but currently I can't get any other media player.

[serge73]

I confirm there is a problem on samsung (tizen).
All apps that use github.com/anacrolix/dms have problems with Samsung TVs.

Using media players is a bad decision.

[WithoutPants]

Can you guys confirm if DLNA works with Kodi or some other open source program? I might be able to compare our implementation with a working one.

[ghost]

@WithoutPants I believe upstream has fixed some issues related to Samsung browsing. Might be worth updating. anacrolix/dms#85

They also have a pending PR that fixes LG/Samsung playback issues. anacrolix/dms#86

[kermieisinthehouse]

Hi everyone,

If you have a samsung TV / other model and could not get UPNP working, can you please test the Stash version at https://github.com/stashapp/stash/actions/runs/1606131148 (downloads at the bottom). If this does fix your problem, we will work with upstream to get that merged and into a Stash release.

[serge73]

kermieisinthehouse, I tested the build for windows.
Tested on windows 11.
Results:

1. VLC - ok
2. Network in Windows Explorer - no UPNP DLNA stash, others (miniDLNA, servio, TorrServer) are visible.
3. samsung Smart TV (UE55HU7200, 2014) - stash visible, but no content
4. samsung Tizen 6.0 (2021) - stash visible, but no content
5. LG (2020) - ok
6. Android Xiaomi Mi 8 - ok

[ghost]

Hi everyone,

If you have a samsung TV / other model and could not get UPNP working, can you please test the Stash version at https://github.com/stashapp/stash/actions/runs/1606131148 (downloads at the bottom). If this does fix your problem, we will work with upstream to get that merged and into a Stash release.

I'm not sure updating the vendor module is enough. Parts of the module is copied into stash for integration purposes, and I think most of the changes in anacrolix/dms#85 have to be manually applied to our copies as well.

[serge73]

kermieisinthehouse, I tested the build for linux.
Tested on debian 11.
Results:

1. VLC - stash visible, but no content
2. Network in Windows Explorer - no UPNP DLNA stash, others (miniDLNA, servio, TorrServer) are visible.
3. samsung Smart TV (UE55HU7200, 2014) - stash visible, but no content
4. samsung Tizen 6.0 (2021) - stash visible, but no content
5. LG (2020) - stash visible, but no content
6. Android Xiaomi Mi 8 - stash visible, but no content

At the same time, I could watch the video through the web interface http://192.168.1.10:9999/scenes/15?qfp=1&qsort=date

[kermieisinthehouse]

Infinite, I didn't realize we copied it directly. I'll look into that.

For the testers, thanks for the feedback. I'll get a new version out to see if I can fix it further. Btw, if you can see Stash but it has no content, it probably means that the IP is blocked in the settings

[ctyjiuh]

I also tested DLNA from Kodi and it works on my Samsung Tizen TV

[anacrolix]

Do you have additional information on whether anacrolix/dms#86 improved your DLNA situation? I'm considering merging it upstream.

[ctyjiuh]

I'm sorry for question - novice in github.
How do I check this?
Install this https://github.com/anacrolix/dms and check DLNA working?

[anacrolix]

@ctyjiuh in this project, I believe if you use #2155 you will be including the PR in dms. If you use dms alone, you will need to checkout and build anacrolix/dms#86.

[salamnkalalo]

Tested on the latest Ubuntu.
VLC - stash visible with content
Network in Windows Explorer - no UPNP DLNA stash, miniDLNA is visible.
Quest deoVR player not visible

[anacrolix]

Can you please consider making a PR upstream?

I note that anacrolix/dms was vendored (with licence), and now parts of it have been internalized into stash (and the licence file went missing). Could you please ensure the licence file is clearly displayed per the licence requirement at https://github.com/anacrolix/dms?tab=BSD-3-Clause-1-ov-file#readme. This isn't the first time anacrolix/dms has been copied by another project (rsync for example). It is my goal to ensure that all the annoying tweaks required for different players arrive in anacrolix/dms so we can all share the small wins we make using this awful, inconsistent protocol. That won't work if people keep copying huge chunks of it and making independent fixes.

[WithoutPants]

Code that was internalised from anacrolix/dms has the license in the affected files:

• stash/internal/dlna/dms.go

  Line 3 in 12af7d6

  // Derived from: https://github.com/anacrolix/dms

• stash/internal/dlna/cd-service-desc.go

  Line 3 in 12af7d6

  // From: https://github.com/anacrolix/dms

• stash/internal/dlna/cds_test.go

  Line 3 in 12af7d6

  // From: https://github.com/anacrolix/dms

• stash/internal/dlna/html.go

  Line 3 in 12af7d6

  // From: https://github.com/anacrolix/dms

I'm happy to add whatever is required, but I'm not sure what else is needed.

I'll look at an upstream PR in the near future. Thanks for your work on anacrolix/dms :)

[anacrolix]

Looks good. Thank you!