fix: MetaMask Virtual Wallet to support on demand connect #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avimak
reviewed
Nov 1, 2024
| @@ -31,7 +31,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@module-federation/runtime": "^0.1.2", | |||
| "@starknet-io/types-js": "^0.7.7" | |||
| "@starknet-io/types-js": "^0.7.7", | |||
There was a problem hiding this comment.
shouldn't it be under devDependencies?
There was a problem hiding this comment.
Hi , u mean the "@starknet-io/types-js ? didnt aware it is in dependencies
it looks like this is an existing issue,
i would suggest create another PR to fix it
|
will fix the pnpm lock |
|
pnpm lock file should now be good |
|
Looks like the lockfile needs updating again. |
fracek
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following issues:
When the
get-startnetUI is not used andWalletAccountis used with theMetaMask Virtual Walletinstarknet.js, an error is thrown due to theMetaMask Virtual Walletnot being loaded whileWalletAccountsends an API request towallet_requestAccountsduring construction.This PR loads the
MetaMask Virtual Walleton-the-fly whenever the API request is being handled.This PR also adds support for two RPC APIs (
wallet_supportedWalletApiandwallet_supportedSpecs) even if the virtual wallet is not connected.