Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: inform about the previous 'chain_id' name in revision 0 #122

Open
thiagodeev opened this issue Nov 25, 2024 · 0 comments · May be fixed by #121
Open

dev: inform about the previous 'chain_id' name in revision 0 #122

thiagodeev opened this issue Nov 25, 2024 · 0 comments · May be fixed by #121
Labels
enhancement New feature or request

Comments

@thiagodeev
Copy link
Contributor

The SNIP 12 quotes many differences between Revision 0 and 1, but it lacks a description of the chainId field's common old name, which was chain_id.
This is important to maintain backward compatibility because new developers without this information can not create programs capable of handling Revision 0 requests containing the old chain_id field that is different from the current chainId.

SNIP 12 paragraph:
https://github.com/starknet-io/SNIPs/blob/main/SNIPS/snip-12.md#domain-separator

References about the old chain_id name:
argentlabs/argent-x#14
https://community.starknet.io/t/signing-transactions-and-off-chain-messages/66/3
@thiagodeev thiagodeev added the enhancement New feature or request label Nov 25, 2024
@thiagodeev thiagodeev linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update snip-12.md to quote about the old chainId field name. thiagodeev/SNIPs
1 participant
@thiagodeev