Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.3.0 - CI breaks #93

Closed
ChristopherRabotin opened this issue Jun 25, 2023 · 3 comments
Closed

Version 2.3.0 - CI breaks #93

ChristopherRabotin opened this issue Jun 25, 2023 · 3 comments
Labels

Comments

@ChristopherRabotin
Copy link

Hi there,

It seems that the arrow crate depends on half.

├── arrow v42.0.0
│   ├── ahash v0.8.3
│   │   ├── cfg-if v1.0.0
│   │   ├── getrandom v0.2.10
│   │   │   ├── cfg-if v1.0.0
│   │   │   └── libc v0.2.146
│   │   └── once_cell v1.18.0
│   │   [build-dependencies]
│   │   └── version_check v0.9.4
│   ├── arrow-arith v42.0.0
│   │   ├── arrow-array v42.0.0
│   │   │   ├── ahash v0.8.3 (*)
│   │   │   ├── arrow-buffer v42.0.0
│   │   │   │   ├── half v2.2.1
(...)

With the version 2.3.0, the CI on my project seems to break: https://github.com/nyx-space/nyx/actions/runs/5370402979/jobs/9742460842 .

   Compiling half v2.3.0
error[E0425]: cannot find function `_mm_cvtps_ph` in this scope
  --> /root/.cargo/registry/src/index.crates.io-1cd66030c949c28d/half-2.3.0/src/binary16/arch/x86.rs:32:18
   |
32 |     let retval = _mm_cvtps_ph(vec.assume_init(), _MM_FROUND_TO_NEAREST_INT);
   |                  ^^^^^^^^^^^^
  --> /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/../../stdarch/crates/core_arch/src/x86/f16c.rs:33:1
   |
   = note: similarly named function `_mm_cvtph_ps` defined here
   |
help: a function with a similar name exists
   |
32 |     let retval = _mm_cvtph_ps(vec.assume_init(), _MM_FROUND_TO_NEAREST_INT);
   |                  ~~~~~~~~~~~~
help: consider importing this function
   |
1  + use core::arch::x86::_mm_cvtps_ph;
   |

error[E0425]: cannot find function `_mm_cvtps_ph` in this scope
  --> /root/.cargo/registry/src/index.crates.io-1cd66030c949c28d/half-2.3.0/src/binary16/arch/x86.rs:50:18
   |
50 |     let retval = _mm_cvtps_ph(vec.assume_init(), _MM_FROUND_TO_NEAREST_INT);
   |                  ^^^^^^^^^^^^
  --> /rustc/90c541806f23a127002de5b4038be731ba1458ca/library/core/src/../../stdarch/crates/core_arch/src/x86/f16c.rs:33:1
   |
   = note: similarly named function `_mm_cvtph_ps` defined here
   |
help: a function with a similar name exists
   |
50 |     let retval = _mm_cvtph_ps(vec.assume_init(), _MM_FROUND_TO_NEAREST_INT);
   |                  ~~~~~~~~~~~~
help: consider importing this function
   |
1  + use core::arch::x86::_mm_cvtps_ph;
   |

For more information about this error, try `rustc --explain E0425`.

Any idea if there is something I can do to fix this or do I need to wait until arrow fixes something on their end ? Or do you think this could be Github CI being slow at updating all of its dependencies ? (I suspect the latter is possible since another workflow seems to build).

Thanks

@TYPEmber
Copy link

crate image has the same problem.

@starkat99
Copy link
Owner

starkat99 commented Jun 26, 2023

This was a build failure on this crate side for i686 targets, that was accidentally dropped from CI. Released version 2.3.1 that fixes the issue and i686 targets are back in CI so it shouldn't happen again.

@ChristopherRabotin
Copy link
Author

Thank you for quickly fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants