feat(Header): add descriptionColor variable

[kuzhelov]

Header - descriptionColor variables

Sets color of Header.Description.

TODO

• Conformance test
• Minimal doc site example
• Stardust base theme
• Teams Light theme
• Teams Dark theme
• Teams Contrast theme
• Confirm RTL usage
• W3 accessibility check
• Stardust accessibility check
• Update glossary props table
• Update the CHANGELOG.md

API Proposal

descriptionColor

<Header ... description='...' variables={{ descriptionColor: 'red' }} />

[codecov]

Codecov Report

Merging #78 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   88.35%   88.37%   +0.01%     
==========================================
  Files          47       47              
  Lines         773      774       +1     
  Branches      100      101       +1     
==========================================
+ Hits          683      684       +1     
  Misses         87       87              
  Partials        3        3

Impacted Files	Coverage Δ
src/components/Header/Header.tsx	95% <100%> (+0.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1692aa...e91536a. Read the comment docs.

[levithomason]

Regarding Layout, you could just use flex-box styling for now if you are blocked. We can add the abstraction later as we find the correct pattern.

[kuzhelov]

new approach to theming is merged with this PR - please, take another look
@levithomason @mnajdova

[mnajdova]

This can be simplified with the following:

    const descriptionElement = HeaderDescription.create(
      descriptionContentOrProps,
      {
        defaultProps: {
          variables: {
            ...(v.descriptionColor && { color: v.descriptionColor }),
          },
        },
        generateKey: false,
      },
    )

[kuzhelov]

thing that I am worrying about is that this is semantically not the same as providing these custom variables as variables property - here, with the suggested approach, those are passed as defaultProps. Shouldn't we instead consider overrideProps from this config object at least?

[mnajdova]

Yes, we can add them in the overrideProps, my comment was just regarding removing the parsing of the descriptionProp considering it can be avoided with the proposed code. If there is no other way, then it can stay like this.

[mnajdova]

Yes, we can add them in the overrideProps, my comment was just regarding removing the parsing of the descriptionProp considering it can be avoided with the proposed code. If there is no other way, then it can stay like this.