-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
configFileName: __PERF__ | ||
? paths.base('build/tsconfig.perf.json') | ||
: paths.base('build/tsconfig.docs.json'), | ||
configFileName: paths.base('build/tsconfig.perf.json'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config is used only for perf stuff, cruft
@@ -37,9 +37,7 @@ const webpackConfig: any = { | |||
exclude: /node_modules/, | |||
options: { | |||
useCache: true, | |||
configFileName: __PERF__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets introduce breaking change entry for that in the CHANGELOG, because, in fact, this change implies potential breaking changes in rendering behavior (as Fela's major version is updated)
…/stardust-ui/react into chore/update-fela # Conflicts: # CHANGELOG.md
@@ -16,7 +16,9 @@ export interface ProviderConsumerProps { | |||
/** | |||
* The Provider's Consumer is for accessing theme. | |||
*/ | |||
const ProviderConsumer: React.SFC<ProviderConsumerProps> = props => <FelaTheme {...props} /> | |||
const ProviderConsumer: React.SFC<ProviderConsumerProps> = ({ render }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had prev here spreading all props, not just the render, not sure if there were other props here, but it may be worth taking a look...
Measures captured with
yarn cross-env PERF=true gulp perf --times=200
💻comp.js