This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Dialog): Add ability to set custom footer #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2005 +/- ##
==========================================
+ Coverage 75.8% 76.73% +0.92%
==========================================
Files 160 161 +1
Lines 5572 5498 -74
Branches 1614 1586 -28
==========================================
- Hits 4224 4219 -5
+ Misses 1334 1266 -68
+ Partials 14 13 -1
Continue to review full report at Codecov.
|
| DialogFooter.create = createShorthandFactory({ Component: DialogFooter }) | ||
|
|
||
| /** | ||
| * A TooltipContent contains the content of a Tooltip component. |
There was a problem hiding this comment.
Oops, incorrect description...
| </Flex> | ||
| ), | ||
| }, | ||
| }) |
There was a problem hiding this comment.
This thing looks really weird, but we agreed to tackle it separately.
|
@kolaps33 Let's also add |
| @@ -15,6 +15,11 @@ const DialogContentExamples = () => ( | |||
| description="A dialog can contain an action in the header." | |||
| examplePath="components/Dialog/Content/DialogExampleHeaderAction" | |||
| /> | |||
| <ComponentExample | |||
| title="Footer" | |||
| description="A dialog can contain a custom footer." | |||
There was a problem hiding this comment.
Suggested change
| description="A dialog can contain a custom footer." | |
| description="A dialog can contain a footer." |
I want to keep this thing aligned with other examples.
docs/src/examples/components/Dialog/Content/DialogExampleFooter.shorthand.tsx
Outdated
Show resolved
Hide resolved
docs/src/examples/components/Dialog/Content/DialogExampleFooter.shorthand.tsx
Show resolved
Hide resolved
| return ( | ||
| <Flex styles={styles}> | ||
| {/* <Button text>Privacy notes</Button> */} | ||
| {/* Privacy notes */} |
There was a problem hiding this comment.
Oops, let's remove comments
layershifter
approved these changes
Oct 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.