Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

feat(buttons): update button colors to match current Teams theme #1933

Merged
merged 14 commits into from
Sep 24, 2019

Conversation

notandrew
Copy link
Contributor

@notandrew notandrew commented Sep 13, 2019

before:
image

after:
image

adding darker shadow to purple button:
before:
image

after:
image

dark theme hover state:
before:
image

after:
image

high contrast default buttons:
before:
image

after:
image

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #1933 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
- Coverage   70.27%   70.26%   -0.01%     
==========================================
  Files         893      893              
  Lines        7892     7893       +1     
  Branches     2309     2310       +1     
==========================================
  Hits         5546     5546              
- Misses       2333     2334       +1     
  Partials       13       13
Impacted Files Coverage Δ
...es/teams-dark/components/Button/buttonVariables.ts 0% <ø> (ø) ⬆️
...high-contrast/components/Button/buttonVariables.ts 0% <ø> (ø) ⬆️
...src/themes/teams/components/Button/buttonStyles.ts 2.85% <0%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b28d4...1446025. Read the comment docs.

@vercel vercel bot temporarily deployed to staging September 17, 2019 22:25 Inactive
Copy link
Member

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @codepretty can you please check?

@notandrew notandrew merged commit 762ac20 into master Sep 24, 2019
@notandrew notandrew deleted the feat/buttons-update branch September 24, 2019 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants