This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
fix(MenuItem): make spacebar not scroll the page, fix submenu not closing #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucivpav
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
=========================================
+ Coverage 69.5% 69.71% +0.2%
=========================================
Files 874 874
Lines 7605 7611 +6
Branches 2242 2245 +3
=========================================
+ Hits 5286 5306 +20
+ Misses 2311 2297 -14
Partials 8 8
Continue to review full report at Codecov.
|
lucivpav
changed the title
…to fix/menu-item-space
layershifter
approved these changes
Aug 20, 2019
jurokapsiar
reviewed
Aug 22, 2019
packages/react/src/lib/accessibility/Behaviors/Menu/menuItemBehavior.ts
Outdated
Show resolved
Hide resolved
jurokapsiar
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that pressing space on focused
MenuItemdoes not lead the page being scrolled. The issue is described here: #1708.It also fixes a problem when clicking on a submenu item with keyboard does not lead to the menu to be closed.