This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
feat(menu): automatic positioning inside viewport #1384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1384 +/- ##
==========================================
+ Coverage 73.51% 73.57% +0.06%
==========================================
Files 786 787 +1
Lines 5863 5885 +22
Branches 1703 1734 +31
==========================================
+ Hits 4310 4330 +20
- Misses 1547 1549 +2
Partials 6 6
Continue to review full report at Codecov.
|
kuzhelov
approved these changes
May 23, 2019
miroslavstastny
approved these changes
May 23, 2019
mnajdova
approved these changes
May 23, 2019
a880b2c
to
ee0cabc
Compare
ee0cabc
to
1c8eaef
Compare
layershifter
approved these changes
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
kuzhelov
reviewed
May 28, 2019
packages/react/test/specs/lib/positioner/getScrollParent-test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(menu): automatic positioning inside viewport
Fixes #1360
Description
Open Menus and submenus at lower part of screen
![image](https://user-images.githubusercontent.com/5442794/58024444-7be8e880-7b12-11e9-8484-eb5ddfea6510.png)
Expected Result
menus and submenus are automatically rendered inside viewport (on top)
Actual Result
menus and submenus are cut off when there is not enough space in the viewport 💣
DEMO with current behavior