Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[halley] Reset halley genesis #3846

Merged
merged 2 commits into from
Feb 10, 2023
Merged

[halley] Reset halley genesis #3846

merged 2 commits into from
Feb 10, 2023

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Feb 10, 2023

Reset halley genesis for test

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@nkysg nkysg requested a review from jolestar as a code owner February 10, 2023 04:35
@nkysg nkysg requested review from sanlee42 and welbon and removed request for jolestar February 10, 2023 04:35
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #3846 (a3090d2) into master (7a23803) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head a3090d2 differs from pull request most recent head 09e124e. Consider uploading reports for the commit 09e124e to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3846      +/-   ##
==========================================
- Coverage   54.15%   54.08%   -0.07%     
==========================================
  Files         613      613              
  Lines       67797    67797              
==========================================
- Hits        36711    36660      -51     
- Misses      31086    31137      +51     
Flag Coverage Δ
unittests 54.08% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/genesis_config.rs 81.42% <100.00%> (ø)
network-rpc/core/src/lib.rs 31.15% <0.00%> (-4.91%) ⬇️
network/api/src/peer_provider.rs 51.03% <0.00%> (-2.91%) ⬇️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 41.16% <0.00%> (-2.59%) ⬇️
sync/src/tasks/mock.rs 86.64% <0.00%> (-2.42%) ⬇️
commons/service-registry/src/handler_proxy.rs 62.84% <0.00%> (-1.76%) ⬇️
sync/src/tasks/mod.rs 78.23% <0.00%> (-0.88%) ⬇️
network-p2p/src/protocol/generic_proto/handler.rs 79.78% <0.00%> (-0.83%) ⬇️
chain/api/src/service.rs 17.52% <0.00%> (-0.46%) ⬇️
network-rpc/src/rpc.rs 38.28% <0.00%> (-0.41%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a23803...09e124e. Read the comment docs.

@nkysg nkysg requested a review from nanne007 as a code owner February 10, 2023 06:00
@nkysg nkysg removed the request for review from nanne007 February 10, 2023 06:03
@nkysg nkysg merged commit e3a4b27 into master Feb 10, 2023
@nkysg nkysg deleted the reset_halley branch February 10, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants