[dev branch] move update use new gas meter imp #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.add gas_params for starcoin_vm
2.fix TableHandle code
2.fix TableHandle code
2.fix starcoin_vm gas_meter 3.fix fmt and clippy warnning
nkysg
requested review from
xudon9,
jolestar,
nanne007,
sanlee42 and
templexxx
as code owners
nkysg
changed the title
nkysg
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #3795 +/- ##
==========================================
- Coverage 55.72% 54.61% -1.11%
==========================================
Files 597 612 +15
Lines 64366 67236 +2870
==========================================
+ Hits 35864 36716 +852
- Misses 28502 30520 +2018
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
2.fix genesis gas_meter
2.fix genesis gas_meter
nkysg
changed the title
|
现在正在重新跑下main和barnard的历史数据确定没有问题 |
Benchmark for 6ea337fClick to view benchmark
|
Benchmark for ac5635aClick to view benchmark
|
jolestar
reviewed
Dec 9, 2022
| pub fn from_v5_to_v4(m: &CompiledModule) -> Result<Vec<u8>> { | ||
| anyhow::ensure!(m.version() == VERSION_5, "bytecode version is not v5"); | ||
| let mut bytes = vec![]; | ||
| m.serialize_for_version(Some(VERSION_4), &mut bytes)?; |
There was a problem hiding this comment.
应该需要过滤掉一部分 v4 不支持的 bytecode
从这注释看 是没有新添加bytecode,只有metadata(这部分怎么处理我还没有搞清楚)
https://github.com/starcoinorg/move/blob/dev/language/move-binary-format/src/file_format_common.rs#L382-#L385
/// Version 5: changes compared with version 4
/// +/- script and public(script) verification is now adapter specific
/// + metadata
// Mark which oldest version is supported.
// TODO(#145): finish v4 compatibility; as of now, only metadata is implemented
pub const VERSION_MIN: u32 = VERSION_5;
nkysg
force-pushed
the
dev_gas_meter
branch
2 times, most recently
from
6f17ecc
to
95299df
Compare
Benchmark for 82bccb5Click to view benchmark
|
Benchmark for d6164ddClick to view benchmark
|
nkysg
added a commit
that referenced
this pull request
Jan 31, 2023
gas_schedule: change max gas unit of test env to 400_000_000 [dev branch] move update use new gas meter imp (#3795) * use GasParameter replace costTable * compat GasCost and GasConstants * ErrorContext change to ErrorDescription * update GasConstants member function * ErrorContext change to ErrorDescription * update move TableHandle def * 1.refactor gas-algebra-ext 2.add gas_params for starcoin_vm * 1.fix mpm code 2.fix TableHandle code * 1.fix mpm code 2.fix TableHandle code * fix NativeGasParams * 1.add move stdlib nursery GasParam * update starcoin_natives gas_params * update VmConfig to gas_params * fix GasParams names * add vmconfig to gas_schedule test * add gas meter calc function * remove debug info * fix simple_instruction * fix complex instr and gas_meter * fix gas_meter related charge implement * update starcoin_vm get gas_params * temp remove table_info column * fix charge_move_to and charge_borrow_global * add debug info for gas_meter * fix vector append remove reverse * fix sha2_256 sha3_256 native_function cal zero str * update starcoin-framework * fix gas-algebra config * add test stdlib precompiled * fix test_init_script and test_signer_cap_internal_type_error * update move_stdlib params * Package transaction publish bundle logic * Update move dep for fixing transactional test harness * comment StarcoinFramework checkpoint * compatible legacy AccountDataCache * Fix task help * move bytecode v6 * update starcoin-framework Co-authored-by: jolestar <[email protected]> Co-authored-by: fikgol <[email protected]> Co-authored-by: WGB5445 <[email protected]>
nkysg
added a commit
that referenced
this pull request
Jan 31, 2023
fix harness test gas_schedule: change max gas unit of test env to 400_000_000 [dev branch] move update use new gas meter imp (#3795) * use GasParameter replace costTable * compat GasCost and GasConstants * ErrorContext change to ErrorDescription * update GasConstants member function * ErrorContext change to ErrorDescription * update move TableHandle def * 1.refactor gas-algebra-ext 2.add gas_params for starcoin_vm * 1.add move stdlib nursery GasParam * update starcoin_natives gas_params * update VmConfig to gas_params * add vmconfig to gas_schedule test * add gas meter calc function * update starcoin_vm get gas_params * temp remove table_info column * add debug info for gas_meter * update starcoin-framework * add test stdlib precompiled * update move_stdlib params * Package transaction publish bundle logic * Update move dep for fixing transactional test harness * comment StarcoinFramework checkpoint * compatible legacy AccountDataCache * move bytecode v6 * update starcoin-framework Co-authored-by: jolestar <[email protected]> Co-authored-by: fikgol <[email protected]> Co-authored-by: WGB5445 <[email protected]>
nkysg
added a commit
that referenced
this pull request
Feb 10, 2023
* [compiler] update move [compiler] Upgrade Move and fix compiler error [clippy] Fix clippy error * Merge branch 'master' into update_move * gen new stdlib * fix warning: add phantom for merkle distributor * update move version fix merkle tree test * fix Identifier merge * Update module_upgrade_test.rs * update script update move * check commit * 1.add table native functions 2.gen new stdlib 3.add table native function gas cost in vmconfig * 1.add StateKey,MoveExt, SessionId,MoveResolveExt 2.add session finish_with_extension 3.change WriteSet , TransactionOutput, StateKeyView * add contract_api.json * 1.add halley genesis * gen new stdlib * Merge branch 'master' into update_move * add move table extension flush * add statedb support move table extension with commit and flush * add table item test code * fix warnings * update move repo * fix fmt * reset proxima * add proxima genesis_config.json * branch update_move add docker build * add table_info storage * update starcoin-framework repo * fix clippy warnings * gen new stdlib, reset proxima genesis * add TableItemProof * add TableItemProof * fmt Cargo.toml * add TableItemProof unit_test * change StateKeyView serde Field attributes * [Feature]Add string module (#3626) * add string * fix string * add string in stdlib * new stdlib * Fix String module native * Fix cargo move * add pr build_test * fix execute script (#3705) * add config * fix run script * fix mpm package table test (#3715) * [dev branch]table extension compatible dry run (#3706) * change dry_out return value * reset proxima * close #3732 * mpm: remove tmp code * [dev]Update docker_build.yml docker/setup-buildx-action to 2, Dockerfile rustup version to 1.25.1 (#3771) * Update docker_build.yml * Update Dockerfile * [dev] remove starcoin-x package，update script and config (#3772) * [dev] remove starcoin-x package * remove in toml * update mold flag * remove starcoin-x alias * add back test scripts * fix powershell * use BAD_TRANSACTION_FEE_CURRENCY for test gas_schedule: change max gas unit of test env to 400_000_000 [dev branch] move update use new gas meter imp (#3795) * use GasParameter replace costTable * compat GasCost and GasConstants * ErrorContext change to ErrorDescription * update GasConstants member function * ErrorContext change to ErrorDescription * update move TableHandle def * 1.refactor gas-algebra-ext 2.add gas_params for starcoin_vm * 1.add move stdlib nursery GasParam * update starcoin_natives gas_params * update VmConfig to gas_params * add vmconfig to gas_schedule test * add gas meter calc function * update starcoin_vm get gas_params * temp remove table_info column * update starcoin-framework * add test stdlib precompiled * update move_stdlib params * Package transaction publish bundle logic * Update move dep for fixing transactional test harness * comment StarcoinFramework checkpoint * compatible legacy AccountDataCache * move bytecode v6 * update starcoin-framework Co-authored-by: jolestar <[email protected]> Co-authored-by: fikgol <[email protected]> Co-authored-by: WGB5445 <[email protected]> * abi support u16, u32, u256 * update rpc schema --------- Co-authored-by: LemonHX <[email protected]> Co-authored-by: WGB5445 <[email protected]> Co-authored-by: caojiafeng <[email protected]> Co-authored-by: jiangying <[email protected]> Co-authored-by: jolestar <[email protected]> Co-authored-by: fikgol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information