Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] vm: refactor vm deps to make it compile to mips #3675

Merged
merged 8 commits into from
Aug 23, 2022

Conversation

nanne007
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #3675 (48286ee) into master (424a830) will decrease coverage by 0.71%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3675      +/-   ##
==========================================
- Coverage   28.96%   28.26%   -0.70%     
==========================================
  Files         591      588       -3     
  Lines       50687    50410     -277     
  Branches    23877    23656     -221     
==========================================
- Hits        14676    14241     -435     
- Misses      21930    22312     +382     
+ Partials    14081    13857     -224     
Flag Coverage Δ
unittests 28.26% <50.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/api/src/provider.rs 75.00% <0.00%> (ø)
block-relayer/src/block_relayer.rs 14.74% <ø> (-1.05%) ⬇️
chain/mock/src/mock_chain.rs 35.17% <0.00%> (ø)
chain/src/chain.rs 33.98% <ø> (-1.61%) ⬇️
cmd/miner_client/src/job_bus_client.rs 38.47% <ø> (ø)
cmd/miner_client/src/stratum_client.rs 0.00% <ø> (ø)
cmd/miner_client/src/stratum_client_service.rs 0.00% <0.00%> (ø)
cmd/peer-watcher/src/lib.rs 100.00% <ø> (ø)
cmd/starcoin/src/account/nft_cmd.rs 0.00% <0.00%> (ø)
cmd/starcoin/src/account/transfer_cmd.rs 0.00% <0.00%> (ø)
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad8a48...48286ee. Read the comment docs.

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vm/types/src/lib.rs Outdated Show resolved Hide resolved
@nanne007 nanne007 enabled auto-merge (squash) August 23, 2022 00:46
@nanne007 nanne007 merged commit cb0549f into starcoinorg:master Aug 23, 2022
@nanne007 nanne007 deleted the executor/cleanup branch August 23, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants