Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config] fixdevnet config load muilti time #3622

Merged
merged 2 commits into from
Aug 6, 2022
Merged

[config] fixdevnet config load muilti time #3622

merged 2 commits into from
Aug 6, 2022

Conversation

YouNeedWork
Copy link
Contributor

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3621

@YouNeedWork
Copy link
Contributor Author

@jolestar request review

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #3622 (e5b46b5) into master (06d5321) will increase coverage by 0.27%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3622      +/-   ##
==========================================
+ Coverage   28.95%   29.22%   +0.27%     
==========================================
  Files         589      589              
  Lines       49864    49873       +9     
  Branches    23450    23457       +7     
==========================================
+ Hits        14434    14570     +136     
+ Misses      21274    21235      -39     
+ Partials    14156    14068      -88     
Flag Coverage Δ
unittests 29.22% <0.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
node/src/lib.rs 16.79% <0.00%> (-0.63%) ⬇️
vm/natives/src/lib.rs 80.00% <0.00%> (-10.00%) ⬇️
config/src/helper.rs 37.26% <0.00%> (-3.92%) ⬇️
txpool/src/pool/listener/tests.rs 10.91% <0.00%> (-3.63%) ⬇️
chain/api/src/errors.rs 25.00% <0.00%> (-3.57%) ⬇️
config/src/lib.rs 30.28% <0.00%> (-2.38%) ⬇️
chain/src/verifier/mod.rs 30.99% <0.00%> (-2.11%) ⬇️
vm/transaction-builder/src/lib.rs 26.41% <0.00%> (-1.46%) ⬇️
...mmons/accumulator/src/inmemory/accumulator_test.rs 42.05% <0.00%> (-1.13%) ⬇️
sync/src/sync.rs 27.02% <0.00%> (-1.11%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d5321...e5b46b5. Read the comment docs.

@jolestar jolestar merged commit 0daaf1f into starcoinorg:master Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] The node is repeatedly started, resulting in the 9850 port cannot be used
2 participants