Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[genesis] update k8s config for halley, ensure clear data #3617

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Aug 4, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

2022-08-04T14:22:25.316825891+00:00 INFO - Check genesis file.
2022-08-04T14:22:25.318105457+00:00 ERROR - GenesisVersionMismatch { expect: HashValue(0x356200ff41aadc53c5c33ef963665aa8aa8fb23df749494edabcbeadf48c49de), real: HashValue(0x70df244aa17960420a7c131d268df36040a04299868746d8f6d386f7d9d4c08f) }, please clean your data dir.
bash: line 1:    11 Segmentation fault      (core dumped) /starcoin/starcoin -n halley -d /sc-data --discover-local=true $node_key_flag
Node start fail, try to remove config.

genesis reset 的情况下发生 core dumped,无法正常清理数据,所以修改为发生错误直接清理数据。

Other information

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #3617 (18eef7c) into master (e92d203) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3617      +/-   ##
==========================================
+ Coverage   29.13%   29.29%   +0.17%     
==========================================
  Files         589      589              
  Lines       49864    49864              
  Branches    23450    23450              
==========================================
+ Hits        14522    14602      +80     
- Misses      21191    21234      +43     
+ Partials    14151    14028     -123     
Flag Coverage Δ
unittests 29.29% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/src/consensus.rs 39.69% <0.00%> (-15.87%) ⬇️
network-rpc/core/src/lib.rs 20.00% <0.00%> (-6.00%) ⬇️
vm/types/src/transaction_metadata.rs 59.71% <0.00%> (-4.47%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 23.26% <0.00%> (-3.87%) ⬇️
vm/types/src/token/token_code.rs 35.72% <0.00%> (-3.57%) ⬇️
sync/src/block_connector/write_block_chain.rs 26.16% <0.00%> (-3.07%) ⬇️
commons/accumulator/src/tree_store/mock.rs 28.58% <0.00%> (-2.85%) ⬇️
storage/src/block/mod.rs 54.17% <0.00%> (-2.38%) ⬇️
storage/src/metrics.rs 50.59% <0.00%> (-2.35%) ⬇️
types/src/startup_info.rs 61.49% <0.00%> (-2.22%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92d203...18eef7c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Benchmark for a842b56

Click to view benchmark
Test Base PR %
accumulator_append 599.8±12.31µs 609.4±36.91µs +1.60%
block_apply/block_apply_10 632.4±0.88ms 630.2±0.97ms -0.35%
block_apply/block_apply_1000 64.7±0.07s 64.2±0.03s -0.77%
get_with_proof/db_store 36.7±0.26µs 36.5±0.31µs -0.54%
get_with_proof/mem_store 31.5±0.22µs 31.4±0.21µs -0.32%
put_and_commit/db_store/1 96.2±4.89µs 95.8±4.90µs -0.42%
put_and_commit/db_store/10 856.4±38.41µs 862.8±39.99µs +0.75%
put_and_commit/db_store/100 7.3±0.29ms 7.4±0.31ms +1.37%
put_and_commit/db_store/5 440.3±21.97µs 413.8±21.72µs -6.02%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.5±5.70µs 61.8±5.71µs +0.49%
put_and_commit/mem_store/10 577.7±48.72µs 577.4±47.77µs -0.05%
put_and_commit/mem_store/100 5.7±0.84ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 292.0±25.81µs 292.0±24.75µs 0.00%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 5.4±0.24ms 5.5±0.19ms +1.85%
query_block/query_block_in(10)_times(1000) 53.6±1.67ms 54.8±1.11ms +2.24%
query_block/query_block_in(10)_times(10000) 540.3±15.31ms 545.4±15.42ms +0.94%
query_block/query_block_in(1000)_times(100) 988.5±9.75µs 963.7±9.47µs -2.51%
query_block/query_block_in(1000)_times(1000) 10.0±0.09ms 9.7±0.08ms -3.00%
query_block/query_block_in(1000)_times(10000) 99.8±0.76ms 96.7±0.69ms -3.11%
storage_transaction 1089.1±302.71µs 1099.8±342.28µs +0.98%
vm/transaction_execution/1 707.1±1.17ms 717.2±1.81ms +1.43%
vm/transaction_execution/10 176.1±0.48ms 178.6±0.84ms +1.42%
vm/transaction_execution/20 152.0±0.36ms 153.6±0.26ms +1.05%
vm/transaction_execution/5 232.7±0.53ms 236.4±2.73ms +1.59%
vm/transaction_execution/50 166.8±0.91ms 168.6±0.69ms +1.08%

@jolestar jolestar merged commit 06d5321 into master Aug 5, 2022
@jolestar jolestar deleted the update_k8s_manifest branch August 5, 2022 01:46
Copy link
Collaborator

@yourmoonlight yourmoonlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants