Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] dry run at cli side and print warn log when transaction execute failed #3597

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Aug 1, 2022

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  1. 在 cli 中执行 dry run,状态通过 remote state reader 获取,虚拟机在 cli 中执行,方便 debug。
  2. 交易执行失败后打印 WARN 日志,但方便排查问题。
starcoin --connect ws://barnard.seed.starcoin.org:9870 --local-account-dir ~/.starcoin/barnard/account_vaults  dev deploy --dry-run package.blob

@jolestar jolestar merged commit c2aeb1f into master Aug 3, 2022
@jolestar jolestar deleted the dry_run_local branch August 3, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants